fix(imgui): update modifier keys and mouse button keys after consuming the message queue#3775
Open
AvarianKnight wants to merge 1 commit intocitizenfx:masterfrom
Open
fix(imgui): update modifier keys and mouse button keys after consuming the message queue#3775AvarianKnight wants to merge 1 commit intocitizenfx:masterfrom
AvarianKnight wants to merge 1 commit intocitizenfx:masterfrom
Conversation
…g the message queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix Ctrl+A sporadically not being usable on RedM and fixes
neteventlog 1(or other windows that get moved outside of the main viewport) being forced to be permanently dragged even when it shouldn't be.How is this PR achieving the goal
We use
GetAsyncKeyStateinstead ofGetKeyState, sinceGetKeyStaterelies on the message queue, which we consume before this.I'm not sure why this works on FiveM, it might be related to the OffThreadWindowing code that's usedThat code is practically no-oped.This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: ..
Platforms: Windows
Checklist
Fixes issues