feat(gta-core-five): clamp vehicle entrypoint index#3817
Open
divocbn wants to merge 1 commit intocitizenfx:masterfrom
Open
feat(gta-core-five): clamp vehicle entrypoint index#3817divocbn wants to merge 1 commit intocitizenfx:masterfrom
divocbn wants to merge 1 commit intocitizenfx:masterfrom
Conversation
|
Should there be a guard for numEntryExitPoints == 0 before the clamp? |
Author
Kinda sure that it should be right as is, especially because 2-seat vehicles has 0 numEntryExitPoints. |
|
You're right. I traced through the downstream code and the function already guards against numEntryExitPoints == 0 by skipping the lookup loop entirely and returning false, so the value is never actually used. The fix works as intended. 👍 |
radium-cfx
approved these changes
Feb 9, 2026
Contributor
radium-cfx
left a comment
There was a problem hiding this comment.
Looks good.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Prevent a crash caused by cheaters sending invalid vehicle entry/exit point indices that are serialized and synchronized in cloned vehicle tasks.
How is this PR achieving the goal
This PR clamps the serialized target entry/exit point index for CTaskEnterVehicle and CTaskExitVehicle to the valid range defined by the vehicle model entry/exit points.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3258, 3570, 3717
Platforms: Windows
Checklist
Fixes issues