adds feature to aggregate identical CombatPreview ModifierStrings#372
Open
slothoth wants to merge 1 commit intocivfanatics:mainfrom
Open
adds feature to aggregate identical CombatPreview ModifierStrings#372slothoth wants to merge 1 commit intocivfanatics:mainfrom
slothoth wants to merge 1 commit intocivfanatics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the unit Combat Preview, strength modifers are listed, even if the values are identical. This can lead to UI bloat if many modifiers are present, as seen in the modded example.
To fix this, Modifier strings are stored and duplicate strings are instead aggregated, I.E. In the mod example, I have given the Battlecry promo a second copy of its normal modifier, but instead of +7 twice, it sums it as +14.
I am planning on releasing this change with my own associated mod, but other modders have expressed interest in using it, but are not Lua programmers. I figured a good comprise might be a home in CQUI.