Fix incorrect ISO metadata being written after shrinking#142
Open
Enzime wants to merge 2 commits intoclalancette:masterfrom
Open
Fix incorrect ISO metadata being written after shrinking#142Enzime wants to merge 2 commits intoclalancette:masterfrom
Enzime wants to merge 2 commits intoclalancette:masterfrom
Conversation
When an existing ISO is opened, modified, and written back, the reshuffled layout can be more compact than the original. This causes the parser to miss the second UDF anchor on re-open.
_reshuffle_extents() packs extents sequentially, so when an existing ISO is opened and modified, the reshuffled layout can be more compact than what pvd.space_size reflects. The second UDF anchor was placed at current_extent but the ISO was padded to pvd.space_size, leaving the anchor at a location none of the five parser probe points would check. Set pvd.space_size to current_extent + 1 so the anchor is always at the last extent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to add a new file into a Windows 11 ISO using the following script:
I would get the following error:
With this PR, the output ISO can be successfully opened and read: