Skip to content

check http status code before processing response body#77

Merged
clebs merged 1 commit intoclebs:mainfrom
akhilerm:check-http-status
Mar 3, 2026
Merged

check http status code before processing response body#77
clebs merged 1 commit intoclebs:mainfrom
akhilerm:check-http-status

Conversation

@akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Mar 3, 2026

check the http status code returned when calling github API, this ensures that the correct error is surfaced

Copy link
Owner

@clebs clebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akhilerm,

Thank you so much for your contribution! 🚀

I have just a minor comment.

@akhilerm akhilerm force-pushed the check-http-status branch from 9a84afa to 0da3584 Compare March 3, 2026 15:50
check the http status code returned when calling github API,
this ensures that the correct error is surfaced

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm force-pushed the check-http-status branch from 0da3584 to 742402a Compare March 3, 2026 15:55
@clebs clebs merged commit ff23434 into clebs:main Mar 3, 2026
2 checks passed
@akhilerm akhilerm deleted the check-http-status branch March 3, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants