Show database names in spacetime list#4769
Open
clockwork-labs-bot wants to merge 2 commits intomasterfrom
Open
Show database names in spacetime list#4769clockwork-labs-bot wants to merge 2 commits intomasterfrom
spacetime list#4769clockwork-labs-bot wants to merge 2 commits intomasterfrom
Conversation
bfops
reviewed
Apr 9, 2026
| config: &Config, | ||
| server: Option<&str>, | ||
| identities: Vec<IdentityRow>, | ||
| ) -> Vec<DatabaseRow> { |
Collaborator
There was a problem hiding this comment.
this should just return a Vec<String> of names for a single identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db_namescolumn tospacetime listCloses #1046.
Notes
I looked at #1072 for prior art. This version is adapted to the current
spacetime listimplementation and uses the existingutil::spacetime_reverse_dnshelper rather than calling the endpoint directly.If a database has no names, the command prints
(unnamed).If a reverse-DNS lookup fails, the command prints
(lookup failed)for that row and warns on stderr.Testing
cargo check -p spacetimedb-cli