feat: unit test on subgroup and tracks#156
Open
itzmanish wants to merge 21 commits into
Open
Conversation
The relay-to-relay connection cache (RemotesState.lookup) was keyed by URL only. Coordinator implementations that return the same URL for different namespaces (e.g. scope-based URLs with per-host socket_addr overrides) may see subscribes misrouted to a previously cached upstream host instead of the host the coordinator identified. Include the SocketAddr in the cache key so that different upstream hosts get separate connections even when the coordinator returns the same URL. Connection reuse is preserved for same-URL + same-host combinations, which is correct since namespace identity is carried in MoQT SUBSCRIBE messages, not the connection URL.
moq-rs CLI tools default to binding on [::]:0, which is IPv6-only on macOS and Windows (unlike Linux where it's dual-stack by default). Users hitting IPv4-only hosts get connection failures with no clear indication of the cause. Replace the default UdpSocket::bind with socket2-based binding that explicitly sets IPV6_V6ONLY=false for cross-platform dual-stack support. Detect dual-stack capability at runtime instead of using a compile-time cfg!(target_os) assumption, and thread the result through Config -> Endpoint -> Client for accurate address family detection during DNS filtering. Config::new() now returns Result instead of panicking on bind failure. Args::load() falls back to 0.0.0.0:port with a warning if the default IPv6 bind fails; explicitly provided bind addresses are not subject to fallback.
…al-stack-binding
…into mpandit/RT-569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.