feat: Send plugin logs via OTEL#1807
Conversation
erezrokah
force-pushed
the
feat/add_otel_logs
branch
from
c214c24 to
e61935f
Compare
erezrokah
force-pushed
the
feat/add_otel_logs
branch
from
e61935f to
95412f2
Compare
| record.SetSeverity(otellogSeverity(level)) | ||
| record.SetBody(otellog.StringValue(message)) | ||
| // See https://github.com/rs/zerolog/issues/493, this is ugly but it works | ||
| logData := make(map[string]any) |
There was a problem hiding this comment.
Opened rs/zerolog#682 let's see how that goes 😄
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you just add a general comment (not about the hack, but about what's going on with zerolog + otel? It's very clear with the context of this PR but the code looks complex so it's not clear on its own I think.
| record.SetSeverity(otellogSeverity(level)) | ||
| record.SetBody(otellog.StringValue(message)) | ||
| // See https://github.com/rs/zerolog/issues/493, this is ugly but it works | ||
| logData := make(map[string]any) |
There was a problem hiding this comment.
| record.SetSeverity(otellogSeverity(level)) | ||
| record.SetBody(otellog.StringValue(message)) | ||
| // See https://github.com/rs/zerolog/issues/493, this is ugly but it works | ||
| logData := make(map[string]any) |
There was a problem hiding this comment.
Can you just add a general comment (not about the hack, but about what's going on with zerolog + otel? It's very clear with the context of this PR but the code looks complex so it's not clear on its own I think.
|
Thanks for the review, added a more detailed comment. Someone is reviewing my PR at rs/zerolog#682 but I wasn't able to understand if they are a maintainer or not. |
🤖 I have created a release *beep* *boop* --- ## [4.51.0](v4.50.1...v4.51.0) (2024-07-22) ### Features * Send plugin logs via OTEL ([#1807](#1807)) ([9897b83](9897b83)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
2 participants
Summary
Still WIP, opening for referenceUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)