-
Notifications
You must be signed in to change notification settings - Fork 214
test: Improve screenshot test pages for select + multiselect #4179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Improve screenshot test pages for select + multiselect #4179
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4179 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 873 873
Lines 25653 25653
Branches 9284 9283 -1
=======================================
Hits 24921 24921
- Misses 685 726 +41
+ Partials 47 6 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
84eb935 to
e86348e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the screenshot test pages for select and multiselect components by adding padding to the screenshot area and introducing a toggle button to test virtual scroll functionality.
Changes:
- Added virtual scroll toggle button to both select and multiselect custom render option pages
- Added padding to screenshot areas for better visual testing
- Updated container styles to use
maxInlineSizeand addedblockSizefor better layout control
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pages/select/custom-render-option.page.tsx | Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions |
| pages/multiselect/custom-render-option.page.tsx | Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This improves the dev pages in select + multiselect to have some padding for the screenshot tests as well as a virtual scroll button to toggle and test differences in virtual scroll and normal mode.
Related links, issue #, if available: n/a
How has this been tested?
Manual testing.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.