Skip to content

Conversation

@SpyZzey
Copy link
Member

@SpyZzey SpyZzey commented Jan 9, 2026

Description

This improves the dev pages in select + multiselect to have some padding for the screenshot tests as well as a virtual scroll button to toggle and test differences in virtual scroll and normal mode.

Related links, issue #, if available: n/a

How has this been tested?

Manual testing.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (42be1aa) to head (fa51509).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4179   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         873      873           
  Lines       25653    25653           
  Branches     9284     9283    -1     
=======================================
  Hits        24921    24921           
- Misses        685      726   +41     
+ Partials       47        6   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpyZzey SpyZzey changed the title Test: Improve screenshot test pages for select + multiselect test: Improve screenshot test pages for select + multiselect Jan 9, 2026
@SpyZzey SpyZzey force-pushed the test/add-padding-to-custom-render-option-screenshot-areas branch from 84eb935 to e86348e Compare January 9, 2026 16:35
@SpyZzey SpyZzey marked this pull request as ready for review January 12, 2026 08:41
@SpyZzey SpyZzey requested a review from a team as a code owner January 12, 2026 08:41
@SpyZzey SpyZzey requested review from ClaudioGSDB, Copilot and mxschll and removed request for a team January 12, 2026 08:41
@SpyZzey SpyZzey removed the request for review from ClaudioGSDB January 12, 2026 08:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the screenshot test pages for select and multiselect components by adding padding to the screenshot area and introducing a toggle button to test virtual scroll functionality.

Changes:

  • Added virtual scroll toggle button to both select and multiselect custom render option pages
  • Added padding to screenshot areas for better visual testing
  • Updated container styles to use maxInlineSize and added blockSize for better layout control

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pages/select/custom-render-option.page.tsx Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions
pages/multiselect/custom-render-option.page.tsx Added virtual scroll toggle functionality and improved screenshot area styling with padding and fixed dimensions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SpyZzey SpyZzey added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit a6d66ff Jan 13, 2026
49 checks passed
@SpyZzey SpyZzey deleted the test/add-padding-to-custom-render-option-screenshot-areas branch January 13, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants