retry to remove the pediacluster's finalizer#289
retry to remove the pediacluster's finalizer#289Iceber wants to merge 1 commit intoclusterpedia-io:mainfrom
Conversation
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
|
why does removing finalizer conflict? |
When delete a pediacluster, only the delete timestamp is set, the user or other components may still update this pediacluster, which will cause the resource version to be modified, and removing the finalizer will cause a conflict |
which components may also modify pediacluster when it is on deleting |
|
@wuyingjun-lucky There are other components inside daocloud that update pediacluster, and user updates can also cause the resource version changes. However, the fix for this pr is incorrect:
|
Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use
retry.RetryOnConflictto remove the finalizer of pediaclusterWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: