Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
This PR fixes a bug in the isEngulfed logic where identical candlesticks were incorrectly identified as being engulfed. I have updated the boundary comparisons to ensure that while a candle can share one boundary with the previous one (e.g., equal Open), it must be strictly larger on at least one side to qualify as an engulfing candle.
Fixes #60
Briefly describe your changes and link any related issues.
Checklist
npm test)npm run lint)Additional context
The previous implementation used inclusive >= and <= operators without a secondary check, meaning isEngulfed(candleA, candleA) would return true. This fix maintains inclusivity for "Equal Opens/Closes" (which is common in trading) but correctly returns false for identical bodies.