Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Aug 7, 2025

PR description:

This missing dictionary were found in root-project/root#18402 (comment)

In addition move dictionary of std::monostate to DataFormats/StdDictionaries. In addition move a few other dictionary definitions to their correct packages.

Resolves cms-sw/framework-team#1510

PR validation:

With a developer area created from cms-sw/root#222 (comment) the failed in the test succeeded with these changes.

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48694/45719

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/StdDictionaries (core)
  • SimDataFormats/Associations (simulation)

@Dr15Jones, @civanch, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @denizsun, @fabiocos, @felicepantaleo, @martinamalberti, @missirol, @mmusich, @rovere, @salimcerci, @wddgit, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa204f/47590/summary.html
COMMIT: b69a4ea
CMSSW: CMSSW_15_1_X_2025-08-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48694/47590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076122
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076087
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2025

Comparison differences are related to #48504

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

Pull request #48694 was updated. @Dr15Jones, @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2025

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa204f/47595/summary.html
COMMIT: 7a74f17
CMSSW: CMSSW_15_1_X_2025-08-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48694/47595/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076122
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076073
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 8, 2025

+simulation

@makortel
Copy link
Contributor Author

makortel commented Aug 8, 2025

Comparison differences are related to #47071 and #48504

@makortel
Copy link
Contributor Author

makortel commented Aug 8, 2025

+core

@Moanwar
Copy link
Contributor

Moanwar commented Aug 8, 2025

+Upgrade

@jfernan2
Copy link
Contributor

jfernan2 commented Aug 8, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b737b8 into cms-sw:master Aug 9, 2025
10 checks passed
@makortel makortel deleted the addMissingDictionaries2 branch August 11, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more missing dictionaries

6 participants