-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add missing dictionary to SimDataFormats/Associations
#48694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cmsbuild, please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48694/45719
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @civanch, @kpedro88, @makortel, @mdhildreth, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
Comparison differences are related to #48504 |
|
Pull request #48694 was updated. @Dr15Jones, @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
|
|
+simulation |
|
+core |
|
+Upgrade |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This missing dictionary were found in root-project/root#18402 (comment)
In addition move dictionary of
std::monostatetoDataFormats/StdDictionaries. In addition move a few other dictionary definitions to their correct packages.Resolves cms-sw/framework-team#1510
PR validation:
With a developer area created from cms-sw/root#222 (comment) the failed in the test succeeded with these changes.