Fix company contribution calculation discrepancies in governance data#120
Open
Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Open
Fix company contribution calculation discrepancies in governance data#120Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Conversation
- Add company-level aggregation queries using count(distinct e.id) to both kubernetes and shared project_developer_stats.sql - Prevents double-counting when multiple developers from same company work on same GitHub events - Ensures consistency between companies table and developer activity dashboards for governance decisions - Addresses Istio governance data discrepancy where Google showed 12738 vs 12615 contributions in different views - Fixes potential ranking issues for top 5 company contributions across all CNCF projects Signed-off-by: Arunodoy18 <arunodoy630@gmail.com>
Author
|
I have done the following changes. If anything is needed please do Tell. |
Member
|
Looking good at the 1st glance, but I would have to pull that branch and execute on the test database to confirm and only then I can merge and make it default (not speaking about regenerating all projects already existing data) - I can't do this ATM, will do on my next CNCF working. day after the more urgent migration task, so this is added to my backlog. |
Author
|
Thanks for the update! Sounds good — go ahead with your migration task first. Whenever you get a chance to review it on the test database, I’m here if you need anything from my side. |
Author
|
Any updates on merging? |
Member
|
As I said, I can do this after migration. This is not done yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure that you follow instructions from CONTRIBUTING
Specially: