PycodestyleBear: Process whole output#2904
Open
areebbeigh wants to merge 1 commit intocoala:masterfrom
Open
Conversation
li-boxuan
requested changes
Apr 19, 2019
Member
li-boxuan
left a comment
li-boxuan
left a comment
There was a problem hiding this comment.
Can you add test cases to check and enforce PycodestyleBear processes whole output? That would be good ^^
Member
Author
Done. |
areebbeigh
changed the title
KVGarg
suggested changes
Apr 19, 2019
Contributor
There was a problem hiding this comment.
Trailing whitespaces in PycodestyleBearTest.py file. Please check Travis CI build log for more information. https://travis-ci.org/coala/coala-bears/jobs/522021385#L5994
Please run coala before pushing changes!
areebbeigh
force-pushed
the
issue-2882
branch
2 times, most recently
from
de7d25c to
8bd8fff
Compare
li-boxuan
approved these changes
Apr 21, 2019
bkhanale
approved these changes
May 21, 2019
Member
|
nvm |
This commit modifies process_output to process all the detected problems instead of just the first one. Fixes coala#2882
Member
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies process_output to
process all the detected problems instead
of just the first one.
Fixes #2882
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!