Fixed some run shell variable passing in GH Action workflows #614
+79
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 1285 1285
Lines 46674 46688 +14
Branches 1522 1522
=======================================
+ Hits 43816 43830 +14
Misses 2548 2548
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #614 will not alter performanceComparing Summary
Footnotes |
michelletran-sentry
force-pushed
the
fix_run_shell_vuln
branch
from
28c468d to
dd8e0e7
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
.github/workflows/_self-hosted.yml
Outdated
Comment on lines
96
to
100
| - name: Build self hosted | ||
| if: ${{ steps.cache-self-hosted.outputs.cache-hit != 'true' }} | ||
| run: | | ||
| make ${{ inputs.make_target_prefix }}build.self-hosted | ||
| make ${{ inputs.make_target_prefix }}save.self-hosted | ||
| make "${MAKE_TARGET_PREFIX}"build.self-hosted |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
michelletran-sentry
force-pushed
the
fix_run_shell_vuln
branch
from
dd8e0e7 to
1dfab9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/getsentry/issue/CCMRG-1490
There's a lot of Semgrep entries for these, so I figured we might as well clean them up.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.