Create model registry for export data #620
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
- Coverage 93.87% 93.83% -0.04%
==========================================
Files 1286 1289 +3
Lines 46659 46850 +191
Branches 1522 1517 -5
==========================================
+ Hits 43800 43962 +162
- Misses 2549 2579 +30
+ Partials 310 309 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will improve performance by 29.78%Comparing Summary
Performance Changes
|
| """ | ||
|
|
||
| success: bool | ||
| error: str | None = None |
There was a problem hiding this comment.
is this an error message?
There was a problem hiding this comment.
Yeah, if the export fails. Still subject to change as I go but a loose definition to have smth for now. It would likely be a custom error "failed in Repo export" something like that.
| success: bool | ||
| download_url: str | None = None | ||
| download_expires_at: datetime | None = None | ||
| error: str | None = None |
There was a problem hiding this comment.
is this an error message?
There was a problem hiding this comment.
Yeap, same as the above ^ but for the final, aggregated export.
| "sentry_user_id", | ||
| "sentry_user_data", | ||
| "account_id", | ||
| "user_id", |
There was a problem hiding this comment.
we would need this one still, right? As well as account_id, to maintain proper references
There was a problem hiding this comment.
Or maybe not account_id since that's an excluded model
There was a problem hiding this comment.
Account no, user yes
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
These are types + specifics for how we'll handle certain models/fields on data export.
https://linear.app/getsentry/issue/CCMRG-1991/make-model-exporter-registry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Establishes a registry and types for owner data export.
models_registry.pywith orderedEXPORTABLE_MODELS(parents before children),TIMESCALE_MODELS, andEXCLUDED_MODELSNULLIFIED_FIELDS(sensitive nullable fields) andDEFAULT_FIELDS(NOT NULL fields with default/factory values)get_model_class,get_nullified_fields,get_default_fieldstypes.pydataclasses:ExportConfig,ExportResult,FinalExportResultfor orchestration and result reportingWritten by Cursor Bugbot for commit 28ebcd8. This will update automatically on new commits. Configure here.