Skip to content

Adding show-urls argument to display just the URLs#4

Open
koldbyte wants to merge 1 commit intocoderick14:masterfrom
koldbyte:master
Open

Adding show-urls argument to display just the URLs#4
koldbyte wants to merge 1 commit intocoderick14:masterfrom
koldbyte:master

Conversation

@koldbyte
Copy link
Copy Markdown

Added a new boolean argument --show-urls with default value false.

When set to true, it will display the URLs only and not start any downloads.

This will be very helpful when anybody wants to download through a download manager.

@coderick14
Copy link
Copy Markdown
Owner

Hey. Instead of adding the if condition inside the loop, can you just shift it to line 167 after the URL has been determined? You can just place the condition after the line

courseURL := courseBaseURL + *courseName

@koldbyte
Copy link
Copy Markdown
Author

koldbyte commented Jan 28, 2018

This will print the course URLs not the actual download links.

A better position could be just before the Line: 217 after which bars and WaitGroup has been initialised. I need to print the baseURL + paths[i] so I will have to add a loop again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants