Fix slop #1845
Merged
Fix slop #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have a `safety_assured` method (thanks Opus!) I ran migrations locally to validate they worked, so something about my flow must have triggered a change before the actual commit. Deploying #1844 causes an error: ``` -- safety_assured(nil) D, [2026-02-02T15:53:04.496858 #1236] DEBUG -- : (1.4ms) SELECT pg_advisory_unlock(3010662050404357335) rake aborted! StandardError: An error has occurred, all later migrations canceled: (StandardError) undefined method `safety_assured' for #<ChangeIssuesIdToBigint:0x00007f10e6d28d10 @name="ChangeIssuesIdToBigint", @Version=20260202160000, @connection=nil> /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:964:in `block in method_missing' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:935:in `block in say_with_time' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:935:in `say_with_time' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:954:in `method_missing' /tmp/build_92292fc4/db/migrate/20260202160000_change_issues_id_to_bigint.rb:14:in `up' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:908:in `public_send' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:908:in `exec_migration' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:889:in `block (2 levels) in migrate' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/migration.rb:888:in `block in migrate' /tmp/build_92292fc4/vendor/bundle/ruby/3.2.0/gems/activerecord-7.0.8/lib/active_record/connection_adapters/abstract/connection_pool.rb:215:in ``` I think this wasn't caught in CI since it loads from schema first instead of running all migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a
safety_assuredmethod (thanks Opus!) I ran migrations locally to validate they worked, so something about my flow must have triggered a change before the actual commit.Deploying #1844 causes an error:
I think this wasn't caught in CI since it loads from schema first instead of running all migrations.