Skip to content

Stop using pkg_resources in setup.py #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cottsay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop using pkg_resources in setup.py #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,19 @@
from setuptools import setup

if 'BUILD_DEBIAN_PACKAGE' not in os.environ:
from pkg_resources import parse_version
def _try_parse(raw):
raw = next(iter((raw or '').split('-', 1)))
for part in raw.split('.'):
try:
yield int(part)
except ValueError:
break

from setuptools import __version__ as setuptools_version
minimum_version = '40.5.0'
if parse_version(setuptools_version) < parse_version(minimum_version):
if tuple(_try_parse(setuptools_version)) < (40, 5):
print(
"The Python package 'colcon-notification' requires at least "
'setuptools version {minimum_version}'.format_map(locals()),
'setuptools version 40.5',
file=sys.stderr)
sys.exit(1)

Expand Down
Loading