Conversation
@Amitabitbul Not sure why we would remove the completed flag, it helps in only adding the completed segments to the srt file. |
This helps in changing the server params to change the number of clients and the amount of time a client is allowed to stay connected to the server. |
I will remove it, I needed it only in my project |
|
@Amitabitbul Can you check again that we dont remove the completion flag? Because I can still see that change. |
|
@makaveli10 Done :) |
|
@Amitabitbul thanks for this PR. Would you mind re-basing against current code ? Thanks! |
This pull request includes several changes to the
whisper_live/client.pyfile, focusing on improving the WebSocket connection handling, segment processing, and transcript writing. The most important changes are summarized below:WebSocket Connection Handling:
whisper_live/client.py, whisper_live/client.pyR73-R75)User-Agentheader in the WebSocket connection. (whisper_live/client.py, whisper_live/client.pyR85)Segment Processing:
process_segmentsmethod by removing the check for thecompletedflag. (whisper_live/client.py, whisper_live/client.pyL115-R121)Transcript Writing:
write_srt_filemethod to always append thelast_segmentto the transcript if it exists, regardless of its content. (whisper_live/client.py, whisper_live/client.pyL262-R264)Code Cleanup:
max_clientsandmax_connection_timefrom theon_openmethod and the__init__method of theClientclass. (whisper_live/client.py, [1] [2]