Make reloading more thread-safe. #1137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reloader will determine whether a reload is needed, wait until it's safe to reload, and then do so, before continuing. If delayed worker is run in the same process as application (but in a different thread) and Reloader is not used, there might be interference between the threads when they reload concurrently: constants might be not properly loaded and unloaded. For instance, a constant that is being loaded in the main thread might be too early detected as a new constant in the delayed worker thread and, therefore, not be added to the list of autoloaded constants at the end of the loading in the main thread, which then leads to the constant not being unloaded, which then leads to such errors as "A copy of ... has been removed from the module tree but is still active!". Also, using Reloader may save resources since code will be reloaded not every few seconds but only when a reload is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reloader will determine whether a reload is needed, wait until it's safe to reload, and then do so, before continuing.
If delayed worker is run in the same process as application (but in a different thread) and Reloader is not used, there might be interference between the threads when they reload concurrently: constants might be not properly loaded and unloaded. For instance, a constant that is being loaded in the main thread might be too early detected as a new constant in the delayed worker thread and, therefore, not be added to the list of autoloaded constants at the end of the loading in the main thread, which then leads to the constant not being unloaded, which then leads to such errors as "A copy of ... has been removed from the module tree but is still active!".
Also, using Reloader may save resources since code will be reloaded not every few seconds but only when a reload is required.