Add scope for queue negation #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A worker can now opt to exclude the given queues by setting the `exclude_specified_queues` option.
If we have jobs without a queue they should be returned by `not_for_queues` unless one of the queues we don't want is specifically `nil`.
When shutting down and releasing jobs, we should still respect the `ActiveRecord.configuration.reserve_sql_strategy` and clear locks using explicit job ids if the strategy is `:default_sql`. This can help avoid transaction isolation conflicts when shutting down several job runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling the
exclude_specified_queuesflag on the worker, added in collectiveidea/delayed_job#1148. This flag indicates whether the list of queues is an inclusion or exclusion filter, allowing delayed job to create worker pools that process any jobs except those in the list of queues.