Skip to content

bring back dataframe with a bump#411

Merged
juhp merged 1 commit intomasterfrom
lts24-dataframe
Apr 19, 2026
Merged

bring back dataframe with a bump#411
juhp merged 1 commit intomasterfrom
lts24-dataframe

Conversation

@juhp
Copy link
Copy Markdown
Member

@juhp juhp commented Apr 4, 2026

dataframe-0.2 fell out of lts-24 when we moved to 9.10.3 (due to its text bump) - this brings back dataframe-0.3.

The version bump might not be ideal, but I still feel better than not shipping it at all.

Checklist for adding a package:

  • Meaningful commit message, eg add my-cool-package (please don't mention the yaml file)

  • Package is already added to nightly (if possible)

  • On your machine, in a new directory, you have successfully run the following set of commands (replacing $package and $version with the name and version of the package you want to add to Stackage LTS):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts
    stack --resolver lts build --haddock --test --bench --no-run-benchmarks
    

or using the verify-package script:

  verify-package $package lts

(seems a bug that github renders this with so much vertical space?)

@juhp juhp changed the title bring back dataframe though with a bump bring back dataframe with a bump Apr 4, 2026
@juhp
Copy link
Copy Markdown
Member Author

juhp commented Apr 6, 2026

Though if we are bumping the version in LTS anyway - it might make better sense to just go to a higher version of dataframe perhaps? 0.7 (down to 0.5) all seem to build with ghc-9.10.3, but not 1.x.

(Normally we prefer not to bump major version of course, that would require a revision of 0.2)

cc @mchav

@juhp juhp merged commit b1a8b26 into master Apr 19, 2026
1 check passed
@juhp juhp deleted the lts24-dataframe branch April 19, 2026 08:03
@juhp
Copy link
Copy Markdown
Member Author

juhp commented Apr 20, 2026

Unfortunately dataframe-0.3.4.1 failed to build:

       /home/curators/work/unpack-dir/unpacked/dataframe-0.3.4.1-10e1b8f9e797c844024cca7da03f09be0d5bda7b6e5c8970f08b45a2a098dd1f/src/DataFrame/Operations/Permutation.hs:68:47: error: [GHC-88464]
           Variable not in scope:
             uniformShuffleList :: [Int] -> g -> ([Int], b0)
          |
       68 | shuffledIndices pureGen k = VU.fromList (fst (uniformShuffleList [0 .. (k - 1)] pureGen))
          |                                               ^^^^^^^^^^^^^^^^^^

juhp added a commit that referenced this pull request Apr 20, 2026
This reverts commit 9ebd488.

dataframe-0.3.4.1 failed to build

cc @mchav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant