fix(generic)!: pods deployed via hooks being used in Deployment/svc - #1449
Merged
Merged
Conversation
Contributor
Author
|
Should superseed #1441 |
stefanandres
force-pushed
the
hook-deployment-bleed
branch
from
September 3, 2026 08:51
2f36baf to
e7c424f
Compare
stefanandres
changed the title
stefanandres
force-pushed
the
hook-deployment-bleed
branch
2 times, most recently
from
September 3, 2026 08:54
3e7c86b to
3c2f14f
Compare
akabanovs
approved these changes
Sep 3, 2026
morremeyer
requested changes
Sep 3, 2026
morremeyer
left a comment
morremeyer
left a comment
Member
There was a problem hiding this comment.
Since we're changing the labels for hooks here, and people might have dependencies on that, we should release it as a breaking change.
Upgrade note proposal:
## 9.x.y to 10.0.0
This release updates the labels for the hook pods. If you do not use hooks, or do not have dependencies on hook pod labels matching specific values, no action is needed.
If you reference hook pod labels anywhere, you'll need to update these references to be prefixed with `hooks-`
morremeyer
approved these changes
Sep 3, 2026
morremeyer
changed the title
morremeyer
enabled auto-merge (squash)
September 3, 2026 11:14
morremeyer
force-pushed
the
hook-deployment-bleed
branch
from
September 3, 2026 11:14
c902d46 to
2d48b5b
Compare
morremeyer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pods deployed via hooks being used in Deployment/svc
Hook pods should not be selected by the deployment selectorLabels, so this fix creates unique labels for hook pods.
Added a regression unittest as well.