fix: JS template uses OrkesClients.from() with optional auth#5
Open
nthmost-orkes wants to merge 1 commit intomainfrom
Open
fix: JS template uses OrkesClients.from() with optional auth#5nthmost-orkes wants to merge 1 commit intomainfrom
nthmost-orkes wants to merge 1 commit intomainfrom
Conversation
- Replace orkesConductorClient (requires keyId/keySecret) with OrkesClients.from() where auth fields are optional - Use Mustache sections so keyId/keySecret are only included when auth_key is configured — OSS users get a clean no-auth client - Switch from TaskManager to TaskHandler (consistent with SDK docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The JavaScript worker template was using
orkesConductorClientwhich requireskeyId/keySecret— those render as empty strings for OSS users, causing the client to fail authentication.Changes
orkesConductorClientwithOrkesClients.from()— auth fields are optional inOrkesApiConfig{{#auth_key}}...{{/auth_key}}) sokeyId/keySecretare only included when auth is configuredTaskManagertoTaskHandler(consistent with SDK docs and exports)Works with the CLI fix in conductor-oss/conductor-cli#78 that defaults
server_urltohttp://localhost:8080/api.Related issues
Closes conductor-oss/getting-started#15
🤖 Generated with Claude Code