Skip to content

Update contract changes for KIP-848 regex subscription - #5251

Merged
Pranav Rathi (pranavrth) merged 2 commits into
masterfrom
dev_kip848_regex-contract-change-update-doc
Feb 25, 2026
Merged

Update contract changes for KIP-848 regex subscription#5251
Pranav Rathi (pranavrth) merged 2 commits into
masterfrom
dev_kip848_regex-contract-change-update-doc

Conversation

@pranavrth

Copy link
Copy Markdown
Member

No description provided.

@pranavrth
Pranav Rathi (pranavrth) requested a review from a team as a code owner November 27, 2025 08:39
Copilot AI review requested due to automatic review settings November 27, 2025 08:39
@confluent-cla-assistant

Copy link
Copy Markdown

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents contract changes related to KIP-848's regex subscription handling, specifically the shift from client-side to broker-side regex matching with a different regex engine.

  • Adds documentation for regex subscription behavior changes in the KIP-848 consumer protocol
  • Documents the migration from libc regex engine (client-side) to Google RE2/J engine (broker-side)
  • Provides a concrete example of regex pattern incompatibility between protocols

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread INTRODUCTION.md Outdated

@emasab Emanuele Sabellico (emasab) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification I proposed some changes.
There's also a change to the example regex ^topic given using ^topic* is also matching topi and we don't want to add this element that creates confusion about the proposed example change.

Comment thread INTRODUCTION.md Outdated
@airlock-confluentinc
airlock-confluentinc Bot force-pushed the dev_kip848_regex-contract-change-update-doc branch from 0402059 to 7b49a53 Compare February 25, 2026 16:35

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Pranav!

@pranavrth
Pranav Rathi (pranavrth) merged commit dff6b15 into master Feb 25, 2026
4 checks passed
@pranavrth
Pranav Rathi (pranavrth) deleted the dev_kip848_regex-contract-change-update-doc branch February 25, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants