fix(registration): cap default slice count in registration progress plot - #419
Open
sdiebolt wants to merge 3 commits into
Open
fix(registration): cap default slice count in registration progress plot#419sdiebolt wants to merge 3 commits into
sdiebolt wants to merge 3 commits into
Conversation
register_volume's live progress plot rendered every slice of the composite fixed/moving mosaic, which was slow and hard to read for volumes with many slices. MatplotlibRegistrationProgressPlotter now caps the mosaic at 12 evenly spaced slices by default (a readable 4x3 grid), exposed as a new max_composite_slices parameter on register_volume (None restores plotting every slice). The napari progress factory gained the same parameter, kept inert, for call-signature compatibility with register_volume's progress_plotter contract. Fixes #368.
9 slices lay out cleanly as 3x3, a more compact default than 12 (4x3).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register_volume's live progress plot rendered every slice of the composite fixed/moving mosaic, which was slow and hard to read for volumes with many slices.MatplotlibRegistrationProgressPlotternow caps the mosaic at 9 evenly spaced slices by default (a 3x3 grid), exposed as a newmax_composite_slicesparameter onregister_volume(Nonerestores plotting every slice). The napari progress factory gained the same parameter, kept inert, for call-signature compatibility.Closes #368