Packit/TMT: re-enable centos-stream-10-x86_64 tests#2028
Packit/TMT: re-enable centos-stream-10-x86_64 tests#2028kolyshkin wants to merge 1 commit intocontainers:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request re-enables the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully re-enables the centos-stream-10-x86_64 tests by reverting a previous change and utilizing the *centos_copr_targets anchor. This change directly addresses the stated goal of resolving the upstream issue and improves configuration consistency by using an anchor for targets.
I am having trouble creating individual review comments. Click here to see my feedback.
.packit.yaml (104-107)
The removed TODO comment and associated references (lines 104-106) provided valuable historical context regarding the temporary disabling of centos-stream-10-x86_64 tests. While the issue is resolved and the tests are re-enabled, removing this detailed context entirely from the configuration file might make it harder for future maintainers to understand the rationale behind past changes without digging through Git history. Consider adding a concise comment in the vicinity of the re-enabled target to briefly explain the re-enablement and reference the resolved issue, if deemed necessary for future maintainability.
|
(clang-check failure is being fixed in #2027) |
|
TMT tests failed. @containers/packit-build please check. |
|
OK, previously excluded centos-stream-10-x86_64 is working fine now, so this PR is legit. |
The upstream issue (https://issues.redhat.com/browse/RHEL-93307) should be fixed by now, so let's re-enable the tests. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The upstream issue (https://issues.redhat.com/browse/RHEL-93307)
should be fixed by now, so let's re-enable the tests.
This reverts PR #1760.
Related: #1759.