Skip to content

Packit/TMT: re-enable centos-stream-10-x86_64 tests#2028

Open
kolyshkin wants to merge 1 commit intocontainers:mainfrom
kolyshkin:ci-rev-1760
Open

Packit/TMT: re-enable centos-stream-10-x86_64 tests#2028
kolyshkin wants to merge 1 commit intocontainers:mainfrom
kolyshkin:ci-rev-1760

Conversation

@kolyshkin
Copy link
Collaborator

The upstream issue (https://issues.redhat.com/browse/RHEL-93307)
should be fixed by now, so let's re-enable the tests.

This reverts PR #1760.

Related: #1759.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-enables the centos-stream-10-x86_64 tests for the crun-centos package within the Packit configuration. This action restores full test coverage for this specific target, as the upstream issue that necessitated their temporary disablement has now been resolved.

Highlights

  • Test Re-enablement: Re-enabled the centos-stream-10-x86_64 tests for the crun-centos package in the Packit configuration, restoring full test coverage for this target.
  • Revert Previous Change: Reverted the changes introduced by PR Packit/TMT: disable centos-stream-10-x86_64 tests #1760, which had temporarily disabled these tests due to an upstream issue that is now resolved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .packit.yaml
    • Re-enabled centos-stream-10-x86_64 target for crun-centos tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully re-enables the centos-stream-10-x86_64 tests by reverting a previous change and utilizing the *centos_copr_targets anchor. This change directly addresses the stated goal of resolving the upstream issue and improves configuration consistency by using an anchor for targets.

I am having trouble creating individual review comments. Click here to see my feedback.

.packit.yaml (104-107)

medium

The removed TODO comment and associated references (lines 104-106) provided valuable historical context regarding the temporary disabling of centos-stream-10-x86_64 tests. While the issue is resolved and the tests are re-enabled, removing this detailed context entirely from the configuration file might make it harder for future maintainers to understand the rationale behind past changes without digging through Git history. Consider adding a concise comment in the vicinity of the re-enabled target to briefly explain the re-enablement and reference the resolved issue, if deemed necessary for future maintainability.

@kolyshkin
Copy link
Collaborator Author

(clang-check failure is being fixed in #2027)

@packit-as-a-service
Copy link

TMT tests failed. @containers/packit-build please check.

@kolyshkin
Copy link
Collaborator Author

OK, previously excluded centos-stream-10-x86_64 is working fine now, so this PR is legit.

@kolyshkin kolyshkin marked this pull request as ready for review February 27, 2026 03:14
The upstream issue (https://issues.redhat.com/browse/RHEL-93307)
should be fixed by now, so let's re-enable the tests.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant