criu: check for criu_check_version error

[eriksjolund]

Closes: #2029

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of CRIU (Checkpoint/Restore In Userspace) integration by centralizing and improving the error handling for libcriu version checks. It introduces a dedicated helper function to validate the libcriu version, ensuring that failures from the criu_check_version API are correctly interpreted and reported, thereby preventing potential misdiagnoses of issues related to CRIU initialization or an outdated library.

Highlights

• New Helper Function: Introduced a new static helper function, validate_criu_version, to centralize the logic for checking the libcriu version.
• Improved Error Handling: Enhanced error handling for libcriu_wrapper->criu_check_version by explicitly differentiating between a general failure (return value < 0) and an outdated libcriu version (return value == 0).
• Code Refactoring: Refactored the existing libcriu version checks within libcrun_container_checkpoint_linux_criu and libcrun_container_restore_linux_criu to utilize the newly created validate_criu_version function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/criu.c
  • Added validate_criu_version static helper function.
  • Replaced direct criu_check_version calls with validate_criu_version in checkpoint and restore functions.
  • Enhanced error reporting for CRIU version validation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the CRIU version check into a new helper function validate_criu_version to correctly handle errors from criu_check_version. The change is logical, but the new function is missing a required parameter, which will cause a compilation error. My review includes suggestions to fix this.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[giuseppe]

LGTM

[kolyshkin]

lgtm

[kolyshkin]

Rebased to re-run CI.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.