tests: fix running c/r tests in GHA#2037
Draft
kolyshkin wants to merge 2 commits intocontainers:mainfrom
Draft
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Collaborator
Author
|
Nope, this is not the right way either... |
|
TMT tests failed. @containers/packit-build please check. |
Unify criu prerequisite checks where we can, and return a reason to skip a test. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Those were never run properly since python tests do not provide non-zero exit code in case a test has failed. Run it via make. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those were never run properly since python tests do not
provide non-zero exit code in case a test has failed, so no
errors were ever reported to CI.
Run it via make so tap-driver.sh is used.