container: fix createRuntime hooks not receiving bundle path

[giuseppe]

The createRuntime and prestart hooks were receiving "/" as the bundle path instead of the actual container bundle directory. This happened because the do_hooks() function was called with NULL for the cwd parameter, causing it to fall back to getcwd() which returned "/".

Closes: #2025

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where container runtime hooks were not provided with the correct bundle path, leading to potential issues in hook execution. The fix ensures that the prestart and createRuntime hooks receive the accurate container bundle directory, improving the reliability of container lifecycle management. A new test case has been introduced to validate this behavior.

Highlights

• Hook Bundle Path Fix: The createRuntime and prestart hooks were incorrectly receiving the root directory ('/') as the bundle path instead of the actual container bundle directory. This has been corrected by passing the context->bundle to the do_hooks function.
• New Test Case: A new test, test_createRuntime_hook_bundle_path, has been added to verify that the createRuntime hook now correctly receives and processes the container's bundle path.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/container.c
  • Modified do_hooks calls for prestart and create_runtime hooks to pass context->bundle instead of NULL for the current working directory parameter.
• tests/test_hooks.py
  • Added test_createRuntime_hook_bundle_path to verify the createRuntime hook receives the correct bundle path.
  • Registered the new test function in the test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where createRuntime and prestart hooks received an incorrect bundle path (/). The fix correctly passes the bundle path from the container's context to the do_hooks function. A new test, test_createRuntime_hook_bundle_path, has been added to verify that the hook now receives the correct, absolute bundle path. The changes are accurate and the accompanying test is thorough, ensuring the fix is effective. The implementation looks good.