Conversation
iamsudip
force-pushed
the
main
branch
3 times, most recently
from
64fd609 to
9ee2de6
Compare
| if len(releases) == 0 { | ||
| return fmt.Sprintf("No history found for release %s", name), nil | ||
| } | ||
| if max > 0 && len(releases) > max { |
There was a problem hiding this comment.
I had to do it manually here cause helm cli also does same, the history object has a field Max, but that is still not used in history.Run() method to limit the result. So we fetch all, limit on client side to mimic the same behaviour of cli.
|
@manusa @ardaguclu Please review! |
Don't worry, we'll look into it. One of the things we want to consider is if we want to keep having helm as part of the default toolsets or make it opt-in instead. |
|
Actually I did and it generated some extra docs, I see which you have already merged. I will rebase the branch and re-run. Right now it's part of helm toolset, are you looking to make helm toolset optional in future? |
|
@manusa I reran |
|
@manusa reminder to have a look, sorry to ping you again, I have rebased my changes again. |
iamsudip
force-pushed
the
main
branch
2 times, most recently
from
810f900 to
a97af24
Compare
|
Hi @manusa @ardaguclu can you please have a look, this has been pending for long. I want to add helm rollback as well to the mcp in another PR. |
Signed-off-by: iamsudip <sudip.maji@harness.io>
Signed-off-by: iamsudip <sudip.maji@harness.io>
2 participants
No description provided.