docs(podman-systemd.unit.5.md): document protocol support for PublishPort Fixes: #28146#28163
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the documentation for the PublishPort option in Podman systemd units by explicitly documenting protocol support (tcp, udp, sctp), addressing a gap identified in issue #28146 where users discovered protocol specification worked but wasn't documented.
Changes:
- Added protocol documentation to three
PublishPortsections (Container, Pod, and Kube units) - Included format example showing protocol syntax:
hostPort:containerPort/tcp - Listed valid protocols: tcp, udp, and sctp
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
2 similar comments
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
mb, messed up the order a little, i will fix it asap and squash them |
ysinghc
force-pushed
the
docs-publishport-protocol
branch
from
6a36aaf to
14c4608
Compare
|
@danishprakash Did the changes and squashed them |
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
I have one comment; otherwise, LGTM. Thanks.
…Port Fixes: containers#28146 Signed-off-by: Yuvraj Singh Chauhan <ysinghcin@gmail.com> Update docs/source/markdown/podman-systemd.unit.5.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yuvraj Singh Chauhan <24429@iiitu.ac.in> Update docs/source/markdown/podman-systemd.unit.5.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yuvraj Singh Chauhan <24429@iiitu.ac.in> Update docs/source/markdown/podman-systemd.unit.5.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yuvraj Singh Chauhan <24429@iiitu.ac.in> docs(podman-systemd.unit.5.md): clarify supported protocols for PublishPort Update docs/source/markdown/podman-systemd.unit.5.md Co-authored-by: Danish Prakash <contact@danishpraka.sh> Signed-off-by: Yuvraj Singh Chauhan <24429@iiitu.ac.in> docs(podman-systemd.unit.5.md): update valid protocols for PublishPort to include sctp (rootful only) docs(podman-systemd.unit.5.md): clarify supported protocols for PublishPort
ysinghc
force-pushed
the
docs-publishport-protocol
branch
from
14c4608 to
30f0673
Compare
|
LGTM |
|
@mheon, PTAL |
|
LGTM |
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?