Skip to content

Fix Assets publish job on default branch pushes#1249

Open
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:fix/assets-workflow-default-branch
Open

Fix Assets publish job on default branch pushes#1249
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:fix/assets-workflow-default-branch

Conversation

@ohmyfelix
Copy link

Summary

  • fix the default-branch Assets pipeline by preventing the publish job from running on regular push events
  • keep package publishing available for manual runs via workflow_dispatch
  • this avoids failing master pipelines when npm publish credentials are missing/invalid

Root cause

The publish job was triggered on every push to master and executed npm publish with secrets.NPM_TOKEN. Recent default-branch runs failed in that step with npm registry auth errors, causing the whole Assets workflow to fail.

Validation

  • gh run view 21982516272 --repo contributte/datagrid --log-failed (shows failing npm publish auth step)
  • npm install && npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants