Fix: Replace Bootstrap 4 deprecated classes with Bootstrap 5 equivalents#1258
Fix: Replace Bootstrap 4 deprecated classes with Bootstrap 5 equivalents#1258radimvaculik wants to merge 2 commits intomasterfrom
Conversation
8076c5f to
f8f92bf
Compare
- dropdown-menu-right -> dropdown-menu-end - control-label -> form-label - form-inline -> d-flex - input-group-addon -> input-group-text - Fix typo: datagrid-col-filter-datte-range-delimiter -> datagrid-col-filter-date-range-delimiter Closes #1257
f8f92bf to
b14c18d
Compare
|
@radimvaculik There are some ramains of old class names: $ grep -nr control-label vendor/ublaboo/datagrid
vendor/ublaboo/datagrid/assets/css/datagrid.css:608: [data-datagrid-name] .datagrid-th-form-inline .control-label {Otherwise looks good. |
- Remove .bootstrap-select styles (not a project dependency) - Remove .form-group, .radio, .checkbox styles (Bootstrap 3 remnants) - Remove .control-label style (replaced by .form-label in BS5) - Remove .input-group-text height hack (BS3/4 specific)
|
@foxycode Thanks. Fixed & removed also obsolete bootstrap-select selectors. |
|
@radimvaculik Everything seems to work. |
|
Hello, does the button for showing/hiding columns work for you? I tried this version and the menu does not expand when clicked. |
|
Looks like hideable columns really does not work. Ajax si called, but column stays displayed. Not sure if it's related to this commit. None of removed styles contains display or similar property. |
|
@AdamFiser @foxycode Everything is working for me. Could you please provide more details or a reproduction example? You can use the datagrid-skeleton repo to demonstrate the issue. |
|
@radimvaculik You simply allow hideable columns using Then try hide something. It won't work. |
|
Yes, the parameters
as if it did not know JavaScript, but it is loaded. |
|
Guys, all good on my side :/ |
|
Sorry, I found the cause, my mistake. |
Summary
dropdown-menu-rightwithdropdown-menu-endcontrol-labelwithform-labelacross all filter templatesform-inline(removed in BS5) withd-flexinput-group-addonwithinput-group-textdatagrid-col-filter-datte-range-delimiter→datagrid-col-filter-date-range-delimiterCloses #1257