refactor(payment): centralize payment methods resolution#5191
Open
hackmanser wants to merge 3 commits intocoopcycle:masterfrom
Open
refactor(payment): centralize payment methods resolution#5191hackmanser wants to merge 3 commits intocoopcycle:masterfrom
hackmanser wants to merge 3 commits intocoopcycle:masterfrom
Conversation
Member
|
@hackmanser why did you close it? |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4927.
Summary
Centralize payment-method availability resolution into
PaymentMethodsResolverand reuse it in API + checkout + selection endpoint.Changes
AppBundle\Payment\PaymentMethodsResolver+ResolvedPaymentMethod.src/Action/Order/PaymentMethods.phpandsrc/Form/Checkout/CheckoutPaymentType.php.Notes
apple_pay/google_payremain API-only (not shown in checkout form).cardis excluded when the restaurant has Pawapay disabled.Testing
docker compose run --rm php vendor/bin/phpunit --filter PaymentMethodsResolverTestCI (fork)