Fixed alumni Card responsivity for tablet/mobile#1143
Open
valerie-wong wants to merge 2 commits intomainfrom
Open
Fixed alumni Card responsivity for tablet/mobile#1143valerie-wong wants to merge 2 commits intomainfrom
valerie-wong wants to merge 2 commits intomainfrom
Conversation
Member
|
[diff-counting] Significant lines: 49. |
ladriennel
requested changes
Mar 21, 2026
Collaborator
ladriennel
left a comment
There was a problem hiding this comment.
Hi val, the ui changes look good! I only have 1 comment about a slight formatting thing with the grids.
| @@ -235,15 +229,15 @@ | |||
|
|
|||
| .infoGrid { | |||
Collaborator
There was a problem hiding this comment.
I notice that right now the grid format of the smaller screens is uneven as "Subteam on DTI" field is falling into a 4th row. I think to fix, this base .infogrid should be display: grid not flex. We can set the default columns/rows here and have the overriding column changes in the breakpoint .infogrids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I adjusted the styling of the Alumni Cards to be more responsive to different screen sizes and handle long text better.
BEFORE:
Right now you can see that depending on how long some of the words are, the spacing of the fields is uneven.
As is, it’s not a huge issue, but when the screen changes sizes then it starts getting weird:
My PR changes the layout of the cards different by screen siz
To test this, I would try messing with the screen widths and seeing how they funtion. I would run through searching through alums and filters to see if tehre are also any other edge cases that break. One thing to note, is that on tablet, the filter bar on the left takes up a lot of space. I believe this is out of scope for this specific task as it lies within the Map layout as opposed to just the Alumni Card Component.