Skip to content

feat: Add Minors field#117

Merged
nadia-choop merged 4 commits intomainfrom
nadia-add-minors
Mar 18, 2026
Merged

feat: Add Minors field#117
nadia-choop merged 4 commits intomainfrom
nadia-add-minors

Conversation

@nadia-choop
Copy link
Copy Markdown
Collaborator

@nadia-choop nadia-choop commented Mar 17, 2026

Summary

Updates to the Edit Profile and Preview Profile pages, and updates for the other user.

  • implemented both backend changes to add minors field, with logic to limit max number of minors
  • implemented frontend changes, correctly updating Edit Profile and Preview Profile pages and for other user (for no minors, one minor, multiple minors)
  • implemented frontend logic to limit maximum number of minors that can be added (4, because typical max is 3)
  • fixed frontend logic to limit maximum number of majors (3)
  • fixed filtering logic for majors and minors so duplicated items cannot be added

Test Plan

  • Testing for correlated behavior on both the Edit Profile and Preview Profile pages
    • Beginning with no minors
    • Adding one minor
    • Adding multiple minors
    • Deleting minors when there are multiple
    • Deleting minors out of order / changing order of minors
    • Custom minor as fallback
    • Deleting all minors
    • No repeated minors/majors can be added
  • Tested that changes show up from the other user perspective.
Redi_minors_feature.mov

Most testing functionality

Redi_Minor_field_norepeats.mov

No repeated majors/minors demo

Note: will add sc/screen recording of other user perspective when able to log in to another acc matched w Sona

Notes

Minors taken from official Cornell page

Breaking Changes

None

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026

Deploy Preview for redi-love ready!

Name Link
🔨 Latest commit 7d804a6
🔍 Latest deploy log https://app.netlify.com/projects/redi-love/deploys/69ba31b001def70009aed427
😎 Deploy Preview https://deploy-preview-117--redi-love.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@glopes2023 glopes2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one quick comment about the suggestions filter, but otherwise looks good to me!

Copy link
Copy Markdown
Collaborator

@jacquelinecai jacquelinecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Nadia! Just have one minor fix and you should be good to merge.

@nadia-choop nadia-choop merged commit 8e3833f into main Mar 18, 2026
10 checks passed
@nadia-choop nadia-choop deleted the nadia-add-minors branch March 18, 2026 05:03
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants