fix: persist code+account before DeleteAccount can verify - #921
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 65.41% 65.63% +0.21%
==========================================
Files 319 319
Lines 22209 22198 -11
==========================================
+ Hits 14529 14569 +40
+ Misses 6497 6482 -15
+ Partials 1183 1147 -36
🚀 New features to boost your workflow:
|
aljo242
reviewed
Jan 6, 2026
aljo242
reviewed
Jan 6, 2026
vladjdk
reviewed
Feb 18, 2026
vladjdk
left a comment
Member
There was a problem hiding this comment.
Generally lgtm, needs a small test case addition to ensure we fully satisfy 6780
mmsqe
force-pushed
the
align_selfdestruct
branch
from
February 19, 2026 02:07
eaf13bf to
85b3c3b
Compare
vladjdk
approved these changes
Feb 19, 2026
vladjdk
left a comment
Member
There was a problem hiding this comment.
lgtm, thanks for the added test!
aljo242
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
align selfdestruct behavior as go-ethereum
Closes: #905
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch