Skip to content

fix: persist code+account before DeleteAccount can verify - #921

Merged
aljo242 merged 8 commits into
cosmos:mainfrom
mmsqe:align_selfdestruct
Feb 19, 2026
Merged

fix: persist code+account before DeleteAccount can verify#921
aljo242 merged 8 commits into
cosmos:mainfrom
mmsqe:align_selfdestruct

Conversation

@mmsqe

@mmsqe mmsqe commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Description

align selfdestruct behavior as go-ethereum

Closes: #905


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov

codecov Bot commented Jan 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.63%. Comparing base (0ca6371) to head (85b3c3b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   65.41%   65.63%   +0.21%     
==========================================
  Files         319      319              
  Lines       22209    22198      -11     
==========================================
+ Hits        14529    14569      +40     
+ Misses       6497     6482      -15     
+ Partials     1183     1147      -36     
Files with missing lines Coverage Δ
x/vm/statedb/statedb.go 81.97% <100.00%> (+0.21%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread x/vm/statedb/statedb.go
Comment thread x/vm/statedb/statedb_test.go

@vladjdk vladjdk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, needs a small test case addition to ensure we fully satisfy 6780

Comment thread x/vm/statedb/statedb_test.go
@mmsqe
mmsqe force-pushed the align_selfdestruct branch from eaf13bf to 85b3c3b Compare February 19, 2026 02:07

@vladjdk vladjdk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the added test!

@aljo242
aljo242 added this pull request to the merge queue Feb 19, 2026
Merged via the queue into cosmos:main with commit 5b3406a Feb 19, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot delete contract at previously funded address

3 participants