feat(giscus): allow giscus data-loading to be eager (not lazy)#2614
Open
joshlk wants to merge 2 commits intocotes2020:masterfrom
Open
feat(giscus): allow giscus data-loading to be eager (not lazy)#2614joshlk wants to merge 2 commits intocotes2020:masterfrom
joshlk wants to merge 2 commits intocotes2020:masterfrom
Conversation
joshlk
changed the title
cotes2020
requested changes
Dec 17, 2025
Owner
cotes2020
left a comment
cotes2020
left a comment
There was a problem hiding this comment.
data-loading='eager' is the default behavior, so there's no need to set it manually. Using a site.comments.giscus.lazy_loading: true option would be more intuitive and concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Add a config option for Giscus comments, which allows you to set the iframe data-loading. Currently, it's hard-coded for lazy loading, but this will enable you to set it to load eagerly when the page loads. I personally don't think it's a good user experience for the user to wait for the comments to load once they scroll to the bottom of the page. The default has been kept as lazy loading.