Fix benchmarks: missing ScriptMutability argument#309
Open
lawless-m wants to merge 1 commit intocozodb:mainfrom
Open
Fix benchmarks: missing ScriptMutability argument#309lawless-m wants to merge 1 commit intocozodb:mainfrom
lawless-m wants to merge 1 commit intocozodb:mainfrom
Conversation
run_script() gained a third ScriptMutability parameter but the benchmarks were never updated, so all three bench files fail to compile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_script()gained a thirdScriptMutabilityparameter, but none of the benchmark files were updated. All three (pokec,time_travel,wiki_pagerank) currently fail to compile.This PR adds the missing argument (
ScriptMutability::Mutablethroughout, matching the prior behavior where benches could write) and the necessary import.Test plan
cargo +nightly check -p cozo --benches— clean (benches require nightly due to#![feature(test)], pre-existing)