Upgrade vagrant config to Ubuntu 18.04 and fix mongo 3 incompatibility#519
Open
mduggan wants to merge 1 commit intocpfair:masterfrom
Open
Upgrade vagrant config to Ubuntu 18.04 and fix mongo 3 incompatibility#519mduggan wants to merge 1 commit intocpfair:masterfrom
mduggan wants to merge 1 commit intocpfair:masterfrom
Conversation
mduggan
commented
Oct 21, 2019
| else: | ||
| insert_result = cachedb.dropbox_cache.insert(cache) | ||
| cache["_id"] = insert_result.inserted_id | ||
| if hasattr(insert_result, 'inserted_id'): |
Contributor
Author
There was a problem hiding this comment.
This was the only incompatibility I found with the latest version of things - although I only connected dropbox and runkeeper, but syncing between them worked.
|
Works for me, thanks a lot! |
klofrau
approved these changes
Jan 30, 2020
klofrau
left a comment
There was a problem hiding this comment.
Fresh setup works with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the ability to use vagrant on a fresh checkout. It upgrades to Bionic (18.04).
Travis is showing this as not working, but that's due to the existing problem there - the tests pass when I run them from the local vagrant image, with some minor warnings:
I tried to also update
.travis.ymlconfig (like #502), but I couldn't get it working - something about the newer ubuntus in travis having an IPV6localhostrecord (eg, https://travis-ci.org/mduggan/tapiriik/builds/600559948)(fixes #491)