Compiler: Forwarding calls to PGCompiler.visit_on_conflict_do_update

[amotl]

About

Fixes AttributeError: 'CrateCompilerSA20' object has no attribute 'visit_on_conflict_do_update'.
GH-264 intended to do this already, but the patch added the dispatching to the wrong class.

References

• AttributeError: 'CrateCompilerSA20' object has no attribute 'visit_on_conflict_do_update' #186
• https://github.com/crate/langchain-cratedb/blob/v0.2.0/langchain_cratedb/patches.py

/cc @bgunebakan, @kneth

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ac2cfc1-c0c7-4b13-a504-bee4ba4a2c1e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[amotl]

This other patch proofs integration works well. Errors on CI are unrelated.

• Dependencies: Update to sqlalchemy-cratedb next, remove monkeypatches langchain-cratedb#115

Can you please merge this PR and run a v0.43.1 bugfix release when possible?

[bgunebakan]

Hi @amotl,
Thank you for your quick fix! It looks good, There is no test for this feature so we couldn't catch before. Could you add a test for your change?

[amotl]

Hi @bgunebakan. I only have been able to come up with a downstream patch crate/langchain-cratedb#115 to validate that the change is solid. I currently do not have the capacities to come up with a full-blown test case here, apologies. Maybe @florinutz or @kneth can help, with optional support by Claude?

[bgunebakan]

Superseed by #278

[amotl]

Thank you very much!