Skip to content

superseed #1216#1223

Open
praveenkumar wants to merge 2 commits intocrc-org:release-4.21from
praveenkumar:pr/1216
Open

superseed #1216#1223
praveenkumar wants to merge 2 commits intocrc-org:release-4.21from
praveenkumar:pr/1216

Conversation

@praveenkumar
Copy link
Copy Markdown
Member

@praveenkumar praveenkumar commented Apr 28, 2026

Summary by CodeRabbit

Chores

  • Updated build system repository configuration to target Fedora 44 instead of Fedora 41
  • Enabled security verification checks for package dependencies

cfergeau added 2 commits April 2, 2026 09:49
Disabling it removes one important layer of security. Mirror
repo is only used to build bundle of unreleased version of
microshift, for the releases we use proper cdn channel.
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from anjannath and cfergeau April 28, 2026 08:19
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f88b4daa-bfb0-40ba-aa9b-bad6435dcae4

📥 Commits

Reviewing files that changed from the base of the PR and between 4f08e09 and 05cac35.

📒 Files selected for processing (1)
  • createdisk.sh

Walkthrough

Updates the temporary Fedora "updates" yum repository configuration in a shell script to target Fedora 44 instead of Fedora 41 on aarch64 architecture, and enables GPG signature checking for package verification.

Changes

Cohort / File(s) Summary
Fedora Repository Configuration Update
createdisk.sh
Updates Fedora yum repository name and metalink parameters from Fedora 41 to Fedora 44; enables gpgcheck security validation while retaining repo_gpgcheck=0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 From forty-one to forty-four we hop,
With GPG checks that'll never stop,
The Fedora feeds are fresh and new,
aarch64 rejoices—onward we flew! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'superseed #1216' is vague and does not clearly describe the technical changes made. It references an issue/PR number without explaining what the actual change accomplishes. Use a descriptive title that explains the change, such as 'Update Fedora yum repository to version 44 and enable gpgcheck' to make the PR history more informative.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenkumar
Copy link
Copy Markdown
Member Author

/retest

@cfergeau
Copy link
Copy Markdown
Contributor

Both e2e-microshift and e2e-snc fails with:

gcloud compute instances create ci-op-v60jz4yl-bdc91 --image-family openshift4-libvirt-rhel9 --zone us-central1-c --machine-type n2-standard-16 --boot-disk-type pd-ssd --boot-disk-size 256GB --subnet ci-op-v60jz4yl-bdc91 --network ci-op-v60jz4yl-bdc91
ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - The resource 'projects/XXXXXXXXXXXXXXXXXXXXXXXX/global/images/family/openshift4-libvirt-rhel9' was not found

@praveenkumar
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift 05cac35 link true /test e2e-microshift
ci/prow/e2e-snc 05cac35 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cfergeau
Copy link
Copy Markdown
Contributor

Both e2e-microshift and e2e-snc fails with:

gcloud compute instances create ci-op-v60jz4yl-bdc91 --image-family openshift4-libvirt-rhel9 --zone us-central1-c --machine-type n2-standard-16 --boot-disk-type pd-ssd --boot-disk-size 256GB --subnet ci-op-v60jz4yl-bdc91 --network ci-op-v60jz4yl-bdc91
ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - The resource 'projects/XXXXXXXXXXXXXXXXXXXXXXXX/global/images/family/openshift4-libvirt-rhel9' was not found

I’m guessing this is related to https://github.com/crc-org/snc/issues/1225 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants