Skip to content

Use ocp/candidate-4.21 for 4.21 branch#1224

Open
praveenkumar wants to merge 1 commit intocrc-org:release-4.21from
praveenkumar:fix_mirror_4.21
Open

Use ocp/candidate-4.21 for 4.21 branch#1224
praveenkumar wants to merge 1 commit intocrc-org:release-4.21from
praveenkumar:fix_mirror_4.21

Conversation

@praveenkumar
Copy link
Copy Markdown
Member

@praveenkumar praveenkumar commented Apr 28, 2026

Since 4.21 is released and ocp-dev-preview only provide payload for non released version so better to use that. Also remove microshift pre release flag from ci script since that is also released.

Summary by CodeRabbit

  • Chores
    • Updated CI pipeline configuration for release builds
    • Modified release version resolution to use stable mirror sources instead of development paths

Since 4.21 is released and ocp-dev-preview only provide payload for non
released version so better to use that. Also remove microshift pre
release flag from ci script since that is also released.
@openshift-ci openshift-ci Bot requested review from anjannath and cfergeau April 28, 2026 12:23
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3eb83d8e-d394-4140-a294-2c6facaa2a33

📥 Commits

Reviewing files that changed from the base of the PR and between 4f08e09 and 0917f29.

📒 Files selected for processing (2)
  • ci_microshift.sh
  • snc.sh

Walkthrough

These changes modify CI build configuration: removing the prerelease environment variable from microshift execution and updating mirror paths and release candidate versions in the installer version resolution logic.

Changes

Cohort / File(s) Summary
CI Microshift Execution
ci_microshift.sh
Removed MICROSHIFT_PRERELEASE=yes environment variable from the microshift script invocation, allowing the script to execute with default prerelease behavior disabled.
Installer Version Resolution
snc.sh
Updated default mirror URL from ocp-dev-preview to ocp and changed release candidate path from candidate/ to candidate-4.21/, affecting which release version is resolved when OPENSHIFT_VERSION is unset.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • anjannath
  • gbraad

Poem

🐰 The prerelease flags have hopped away,
Mirror paths now show a brighter day,
Version four-point-twenty-one takes the stage,
Configuration scripts turn a newer page! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Use ocp/candidate-4.21 for 4.21 branch' directly and specifically summarizes the main change in snc.sh, which switches the mirror URL from ocp-dev-preview to ocp/candidate-4.21.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@praveenkumar
Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@praveenkumar
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 29, 2026

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift 0917f29 link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant