fix(hbsig): strip publickey: prefix from keyid before computing address - #2
Open
droter wants to merge 1 commit into
Open
fix(hbsig): strip publickey: prefix from keyid before computing address#2droter wants to merge 1 commit into
droter wants to merge 1 commit into
Conversation
The extractPubKey function was returning the full keyid including the "publickey:" prefix, causing incorrect committer address computation. The keyid format is "type:value" (e.g., "publickey:base64data"). The function now: 1. Strips the prefix before the first colon 2. Converts standard base64 (+/) to base64url (-_) for the decoder This fixes authorization failures where HyperBEAM couldn't match the computed committer address against cache_writers or other ACLs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractPubKeyto properly strip thepublickey:prefix from keyid before computing the committer addressProblem
The keyid format in HTTP signatures is
type:value(e.g.,publickey:base64data). TheextractPubKeyfunction was passing the entire keyid including the prefix tobase64url.toBuffer(), which caused incorrect address computation.This resulted in:
Solution
Test
Before fix:
After fix:
🤖 Generated with Claude Code