Add AppDelegate.swift support#427
Merged
hyochan merged 1 commit intocrossplatformkorea:mainfrom Oct 16, 2025
Merged
Conversation
heyman333
approved these changes
Jul 24, 2025
Contributor
|
@bglgwyng 병합 부탁드립니다. |
Collaborator
Author
|
@utae 머지 권한이 없습니다 |
utae
approved these changes
Sep 10, 2025
Contributor
|
Hi guys, is this ready to merge? Thank you! |
|
혹시 해당 PR사항 머지 준비된 것으로 보이는데, 머지에 대한 업데이트사항 없을까요 ? |
hyochan
reviewed
Oct 16, 2025
|
|
||
| return withAppDelegate(config, (props) => { | ||
| if (['objc', 'objcpp'].includes(props.modResults.language)) { | ||
| props.modResults.contents = modifyContents(props.modResults.contents); |
Member
There was a problem hiding this comment.
해당 PR과는 관련이 없는데 modifySwiftContents가 생기면서 함수 일관성을 위해 modifyObjCContents로 바꿔서 일관성을 유지하는게 좋아보입니다!
hyochan
reviewed
Oct 16, 2025
Comment on lines
+20
to
+22
| const SWIFT_KAKAO_HEADER_IMPORT_STRING = 'import kakao_login'; | ||
|
|
||
| const SWIFT_KAKAO_LINKING_STRING = |
Member
There was a problem hiding this comment.
SUFFIX에 _STRING 보다는 _CODE가 개인적으로 더 의미 부여가 될 것 같습니다.
hyochan
approved these changes
Oct 16, 2025
Member
hyochan
left a comment
hyochan
left a comment
There was a problem hiding this comment.
간단한 네이밍 말고 테스트는 다른분들이 해주신 것 같아 approve 합니다!
Member
|
급하신 분들이 있는것 같아 먼저 병합하고 릴리즈 배포 하겠습니다. |
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.