Separate dashboard into it's own deployment and add persistence#64
Open
FleetAdmiralButter wants to merge 2 commits intocrowdsecurity:mainfrom
Open
Separate dashboard into it's own deployment and add persistence#64FleetAdmiralButter wants to merge 2 commits intocrowdsecurity:mainfrom
FleetAdmiralButter wants to merge 2 commits intocrowdsecurity:mainfrom
Conversation
Member
|
Did you get any chance to take a look again on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is still a work in progress and requires some testing, but I've done some work around fixing #55 so that the dashboard is able to persist changes.
I've also split the dashboard out into a separate deployment so the the LAPI can be run in a high-availability configuration without also having multiple instances of the dashboard running (which consumes significant memory).
Here's a summary of the changes I've made:
values.yamlaccordingly with a dedicated section for the dashboard. By default, I've set apodAffinityso that the dashboard is scheduled onto the same node as the LAPI so that this still works if the user only has access toReadWriteOncestorage classes.replicasfield for the LAPI deployment to allow for it to be deployed in a high-availability configuration.It would be great if I could get some feedback around the direction I'm taking this in. We're using this fork of the Helm chart internally to run a HA CrowdSec LAPI and would like to contribute these changes back.