Add LLVM::Attribute::Cold for overflow handling in function attributes#16754
Closed
kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Add LLVM::Attribute::Cold for overflow handling in function attributes#16754kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
LLVM::Attribute::Cold for overflow handling in function attributes#16754kojix2 wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is intended to present an idea.
I explored LLVM attributes that are not currently used in Crystal but might contribute to performance improvements with the help of LLMs. As a result,
coldemerged as one candidate. As a trial, I added thecoldattribute to the function that raises overflow exceptions. Unfortunately, benchmarks showed no clear improvement and results were slightly slower. I'll close this.