Fix IO::Encoder#write when operating on long strings#16797
Open
jgaskins wants to merge 1 commit intocrystal-lang:masterfrom
Open
Fix IO::Encoder#write when operating on long strings#16797jgaskins wants to merge 1 commit intocrystal-lang:masterfrom
IO::Encoder#write when operating on long strings#16797jgaskins wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
We accomplish this by ignoring `Errno::E2BIG` errors.
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: |
ysbaddaden
added
kind:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes encoding operations on long strings by ignoring
Errno::E2BIGerrors.FWIW, this will need additional testing to ensure that strings with non-ASCII characters still work, but the test included with this PR fails without this patch and passes with it.
Fixes #16796